build(aio): update to @angular/core@5.0.0-rc.5 #19702

IgorMinar · 2017-10-13T17:28:01Z

there is a size regression right now because the CLI is out of date:

-rw-r--r-- 1 iminar eng 14942 Oct 13 10:23 dist/0.b19e913fbdd6507d346b.chunk.js
-rw-r--r-- 1 iminar eng 1535 Oct 13 10:23 dist/inline.812a4af83ecce165c71c.bundle.js
-rw-r--r-- 1 iminar eng 643481 Oct 13 10:23 dist/main.74550bb35f9f5a57e78a.bundle.js
-rw-r--r-- 1 iminar eng 37402 Oct 13 10:23 dist/polyfills.965a9a5ad3e11b17f85e.bundle.js

mary-poppins · 2017-10-17T05:47:00Z

You can preview f9397f9 at https://pr19702-f9397f9.ngbuilds.io/.

gkalpak · 2017-10-18T21:04:49Z

aio/package.json

@@ -82,7 +82,7 @@
    "core-js": "^2.4.1",
    "jasmine": "^2.6.0",
    "ng-pwa-tools": "^0.0.10",
-    "rxjs": "^5.2.0",
+    "rxjs": "5.5.0-beta.7",


We could get to 5.5.0 now 😁

gkalpak · 2017-10-18T21:08:15Z

aio/tools/cli-patches/patch.js

+const fs = require('fs');
+const sh = require('shelljs');
+
+PATCH_LOCK = 'node_modules/@angular/cli/models/webpack-configs/.patched';


PATCH_LOCK --> const PATCH_LOCK(?)

gkalpak · 2017-10-18T21:13:08Z

aio/tools/cli-patches/rxjs-esm-aliases.patch

+             extensions: ['.ts', '.js'],
+             modules: ['node_modules', nodeModules],
+             symlinks: !buildOptions.preserveSymlinks
+           ,alias: require('rxjs/_esm5/path-mapping')(path.resolve(__dirname, '..', '..', '..', '..', '..', 'node_modules'))


path.resolve(__dirname, '../../../../../node_modules') woks too 😁

gkalpak · 2017-10-18T21:19:00Z

aio/tools/cli-patches/patch.js

+PATCH_LOCK = 'node_modules/@angular/cli/models/webpack-configs/.patched';
+
+if (!fs.existsSync(PATCH_LOCK)) {
+  sh.exec('patch -p0 -i tools/cli-patches/rxjs-esm-aliases.patch');


Nit: You might want to use sh.set('-e'), so that if an errors occurs the PATCH_LOCK file isn't touched.

gkalpak · 2017-10-18T21:24:38Z

aio/src/app/app.module.ts

 import { SharedModule } from 'app/shared/shared.module';

-// These are the hardcoded inline svg sources to be used by the `<md-icon>` component
+// These are the hardcoded inline svg sources to be used by the `<mat-icon>` component
 export const svgIconProviders = [


It seems that these icons are not picked up any more:

(Or is it related to the last commit ("deferring the embedded components"), which as discussed will be removed from this PR?)

@gkalpak would you have some extra cycles to help investigate why this is broken? I assume that it has to be related with our custom icon registry.

Yeah, I will look into it.

I verified this is indeed related to the commit that defers loading the embdded components.
So, let's deal with this issue in another PR. (As discussed, deferring embedded components will be removed from this PR. This is still the plan, right?)

I removed the commit that caused this.

gkalpak · 2017-10-18T21:28:12Z

aio/package.json

    "tslib": "^1.7.1",
    "web-animations-js": "^2.2.5",
    "zone.js": "^0.8.16"
  },
  "devDependencies": {
-    "@angular/cli": "^1.3.0",
+    "@angular/cli": "^1.5.0-rc.0",


We could get to rc.1 now 😁

gkalpak · 2017-10-18T21:30:42Z

aio/src/app/app.module.ts

-// crashes with "missing first" operator when SideNav.mode is "over"
-import 'rxjs/add/operator/first';
+import { ROUTES } from '@angular/router';
+import { Platform } from '@angular/cdk/platform';


Why not import it from @angular/material or @angular/material/platform?
Or better yet, import PlatformModule from @angular/material[/platform]?
(Assuming Platform is still necessary in the first place 😃)

I believe that export was deprecated.

mary-poppins · 2017-10-19T00:22:29Z

You can preview 5e4944f at https://pr19702-5e4944f.ngbuilds.io/.

IgorMinar · 2017-10-19T15:49:12Z

sounds good. let's defer the deferring

…

On Thu, Oct 19, 2017 at 3:26 AM George Kalpakas ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In aio/src/app/app.module.ts <#19702 (comment)>: > import { SharedModule } from 'app/shared/shared.module'; -// These are the hardcoded inline svg sources to be used by the `<md-icon>` component +// These are the hardcoded inline svg sources to be used by the `<mat-icon>` component export const svgIconProviders = [ I verified this is indeed related to the commit that defers loading the embdded components. So, let's deal with this issue in another PR. (As discussed, deferring embedded components will be removed from this PR. This is still the plan, right?) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#19702 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6Mjmkrn8_bbe1o0ot9ud6oZQJEUGks5styPegaJpZM4P4zqI> .

googlebot · 2017-10-21T10:13:16Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

IgorMinar · 2017-10-23T13:25:04Z

I think that we should land this and get the fixes for #19857
angular/devkit#231 in a new PR once they are available.

mary-poppins · 2017-10-23T13:29:34Z

You can preview f55a6a8 at https://pr19702-f55a6a8.ngbuilds.io/.

mary-poppins · 2017-10-23T13:38:01Z

You can preview 9e1108e at https://pr19702-9e1108e.ngbuilds.io/.

These are changes that the mat-switcher missed and I had to make them by hand. PR Close #19702

-rw-r--r-- 1 iminar eng 14942 Oct 13 13:35 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 13 13:35 dist/inline.f005f1bd6803b72f5961.bundle.js -rw-r--r-- 1 iminar eng 582527 Oct 13 13:35 dist/main.b9ef1abb785be8de15b8.bundle.js -rw-r--r-- 1 iminar eng 37402 Oct 13 13:35 dist/polyfills.f8409a9eb69060ac1aa6.bundle.js PR Close #19702

-rw-r--r-- 1 iminar eng 14942 Oct 13 14:30 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 13 14:30 dist/inline.702d6ff5146ddc373f05.bundle.js -rw-r--r-- 1 iminar eng 588943 Oct 13 14:30 dist/main.64c96d55a10c56cfd6cd.bundle.js -rw-r--r-- 1 iminar eng 37402 Oct 13 14:30 dist/polyfills.f8409a9eb69060ac1aa6.bundle.js PR Close #19702

-rw-r--r-- 1 iminar eng 14942 Oct 13 14:52 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 13 14:52 dist/inline.6ca24f1c3b848103b041.bundle.js -rw-r--r-- 1 iminar eng 567802 Oct 13 14:52 dist/main.c8183a2c0116782ca366.bundle.js -rw-r--r-- 1 iminar eng 37402 Oct 13 14:52 dist/polyfills.f8409a9eb69060ac1aa6.bundle.js PR Close #19702

-rw-r--r-- 1 iminar eng 14942 Oct 13 16:12 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 13 16:12 dist/inline.eede8140efeab4c45b22.bundle.js -rw-r--r-- 1 iminar eng 559389 Oct 13 16:12 dist/main.20858f9aa7cf8741b6aa.bundle.js -rw-r--r-- 1 iminar eng 37402 Oct 13 16:12 dist/polyfills.f8409a9eb69060ac1aa6.bundle.js PR Close #19702

-rw-r--r-- 1 iminar eng 84219 Oct 18 09:13 dist/0.8ef208c27531d5c6af63.chunk.js -rw-r--r-- 1 iminar eng 14942 Oct 18 09:13 dist/4.c719ac5645940382cdce.chunk.js -rw-r--r-- 1 iminar eng 1560 Oct 18 09:13 dist/inline.adc367eb50c706f3fd04.bundle.js -rw-r--r-- 1 iminar eng 492354 Oct 18 09:13 dist/main.b9d9549455c74aff1480.bundle.js -rw-r--r-- 1 iminar eng 37402 Oct 18 09:13 dist/polyfills.f8409a9eb69060ac1aa6.bundle.js PR Close #19702

-rw-r--r-- 1 iminar eng 84219 Oct 18 21:05 dist/0.0f327734d18211139822.chunk.js -rw-r--r-- 1 iminar eng 14942 Oct 18 21:05 dist/4.c719ac5645940382cdce.chunk.js -rw-r--r-- 1 iminar eng 1560 Oct 18 21:05 dist/inline.887757679ff553e20b54.bundle.js -rw-r--r-- 1 iminar eng 492354 Oct 18 21:05 dist/main.5e5dc9ed980c9f5dc2bd.bundle.js -rw-r--r-- 1 iminar eng 37402 Oct 18 21:05 dist/polyfills.f8409a9eb69060ac1aa6.bundle.js PR Close #19702

-rw-r--r-- 1 iminar eng 84219 Oct 19 21:37 dist/0.0f327734d18211139822.chunk.js -rw-r--r-- 1 iminar eng 14942 Oct 19 21:37 dist/4.c719ac5645940382cdce.chunk.js -rw-r--r-- 1 iminar eng 1560 Oct 19 21:37 dist/inline.887757679ff553e20b54.bundle.js -rw-r--r-- 1 iminar eng 492354 Oct 19 21:37 dist/main.5e5dc9ed980c9f5dc2bd.bundle.js -rw-r--r-- 1 iminar eng 37402 Oct 19 21:37 dist/polyfills.f8409a9eb69060ac1aa6.bundle.js PR Close #19702

-rw-r--r-- 1 iminar eng 14942 Oct 20 22:16 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 20 22:16 dist/inline.68ebcf831dc9c905804f.bundle.js -rw-r--r-- 1 iminar eng 541291 Oct 20 22:16 dist/main.5ec6fb5f95fc0433d822.bundle.js -rw-r--r-- 1 iminar eng 37402 Oct 20 22:16 dist/polyfills.f8409a9eb69060ac1aa6.bundle.js PR Close #19702

This will be fixed in CLI once angular/angular-cli#8130 lands. -rw-r--r-- 1 iminar eng 14942 Oct 20 22:23 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1535 Oct 20 22:23 dist/inline.5d66b81ec9e01af9d28d.bundle.js -rw-r--r-- 1 iminar eng 528395 Oct 20 22:23 dist/main.e36bb99245ca52ae546f.bundle.js -rw-r--r-- 1 iminar eng 37205 Oct 20 22:23 dist/polyfills.0dfca732c5a075c110d0.bundle.js PR Close #19702

… are fixed (#19702) related issues: #19857 angular/devkit#231 PR Close #19702

The use of `System.import()` in test.ts was causing the webpack build to fail with a mysterious "Module build failed: Error: TypeScript compilation failed" error, when running `yarn test`. PR Close #19702

PR Close #19702

….12 (#19702) PR Close #19702

PR Close #19702

The latest builds have added ~2kB to the size of this file (500 bytes zipped). PR Close #19702

These issues appeared after upgrade of eslint jasmine plugin PR Close #19702

Later versions (before 0.8.19) had a size increase. PR Close #19702

…19702) The change of Angular Material version means that the `md` prefix is no longer appropriate. PR Close #19702

PR Close #19702

-rw-r--r-- 1 iminar eng 14880 Oct 30 11:29 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1533 Oct 30 11:29 dist/inline.25600c3b48de18b97581.bundle.js -rw-r--r-- 1 iminar eng 486476 Oct 30 11:29 dist/main.d1292a34401056535884.bundle.js -rw-r--r-- 1 iminar eng 37070 Oct 30 11:29 dist/polyfills.0dfca732c5a075c110d0.bundle.js PR Close #19702

-rw-r--r-- 1 iminar eng 14880 Nov 1 11:57 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1533 Nov 1 11:57 dist/inline.3574d1d784c09c507dbd.bundle.js -rw-r--r-- 1 iminar eng 497812 Nov 1 11:57 dist/main.76bbb69df79eaefef54c.bundle.js -rw-r--r-- 1 iminar eng 37259 Nov 1 11:57 dist/polyfills.fdb71956ccd13330fb47.bundle.js PR Close #19702

This reverts commit f0d530b. cli rc.8 reintroduces the node polyfill which causes size regression, so I'm putting the patch back in. -rw-r--r-- 1 iminar eng 14880 Nov 1 12:11 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1533 Nov 1 12:11 dist/inline.25600c3b48de18b97581.bundle.js -rw-r--r-- 1 iminar eng 486476 Nov 1 12:11 dist/main.d1292a34401056535884.bundle.js -rw-r--r-- 1 iminar eng 37070 Nov 1 12:11 dist/polyfills.0dfca732c5a075c110d0.bundle.js PR Close #19702

build fails - material upgrade required PR Close #19702

-rw-r--r-- 1 iminar eng 14880 Nov 1 12:25 dist/0.b19e913fbdd6507d346b.chunk.js -rw-r--r-- 1 iminar eng 1533 Nov 1 12:25 dist/inline.2826385ad3e299c6d1c1.bundle.js -rw-r--r-- 1 iminar eng 486476 Nov 1 12:25 dist/main.f0610805f4aad19da4be.bundle.js -rw-r--r-- 1 iminar eng 37070 Nov 1 12:25 dist/polyfills.0dfca732c5a075c110d0.bundle.js PR Close #19702

angular-automatic-lock-bot · 2019-09-12T19:51:55Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 13, 2017

IgorMinar added state: WIP and removed cla: yes labels Oct 13, 2017

googlebot added the cla: yes label Oct 13, 2017

IgorMinar mentioned this pull request Oct 18, 2017

build(aio): bump angular to 5.0.0-beta.4 #18839

Closed

IgorMinar requested a review from gkalpak October 18, 2017 19:51

gkalpak requested changes Oct 18, 2017

View reviewed changes

IgorMinar force-pushed the update-aio-deps branch from f9397f9 to 5e4944f Compare October 19, 2017 00:09

IgorMinar force-pushed the update-aio-deps branch from 5e4944f to f1c6ebe Compare October 21, 2017 10:13

googlebot added cla: no and removed cla: yes labels Oct 21, 2017

IgorMinar force-pushed the update-aio-deps branch 3 times, most recently from f4cc647 to 64577d2 Compare October 21, 2017 16:39

petebacondarwin mentioned this pull request Oct 23, 2017

feat(aio): upgrade to latest Angular Material #19869

Closed

IgorMinar added aio: preview action: review The PR is still awaiting reviews from at least one requested reviewer and removed cla: no labels Oct 23, 2017

IgorMinar force-pushed the update-aio-deps branch from f55a6a8 to 9e1108e Compare October 23, 2017 13:27

IgorMinar added comp: aio and removed state: WIP labels Oct 23, 2017

googlebot added the cla: no label Oct 23, 2017

IgorMinar requested a review from petebacondarwin October 23, 2017 13:28

matsko pushed a commit that referenced this pull request Nov 1, 2017

fix(aio): hand fix the renaming md->mat issues (#19702)

253e89d

These are changes that the mat-switcher missed and I had to make them by hand. PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

build(aio): temporarily increaze the size limit until the regressions…

3e05d62

… are fixed (#19702) related issues: #19857 angular/devkit#231 PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

build(aio): remove cli patches (#19702)

5f6d71d

PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

build(aio): fix tests to work with @angular/{material,cdk}@2.0.0-beta…

260c9b7

….12 (#19702) PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

build(aio): revert temporary increase in size limit (#19702)

428f80e

PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

build(aio): upgrade to Angular@rc.5 and CLI@rc.3 (#19702)

d62ef13

PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

build(aio): remove hack to modify CLI version (#19702)

aa57471

PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

ci(aio): increase payload size limit for polyfills.ts (#19702)

e48dc27

The latest builds have added ~2kB to the size of this file (500 bytes zipped). PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

style(aio): fix docs linting issues (#19702)

ced5186

These issues appeared after upgrade of eslint jasmine plugin PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

build(aio): lock zone.js to 0.8.16 (#19702)

71f1ed5

Later versions (before 0.8.19) had a size increase. PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

refactor(aio): rename CustomMdIconRegistry to CustomIconRegistry (#…

7a708ad

…19702) The change of Angular Material version means that the `md` prefix is no longer appropriate. PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

ci(aio): decrease payload size limit for main file (#19702)

7695ad5

PR Close #19702

matsko pushed a commit that referenced this pull request Nov 1, 2017

build(aio): upgrade to @angular/core@5.0.0-rc.9 (#19702)

9c9867e

build fails - material upgrade required PR Close #19702

petebacondarwin removed this from MERGE in docs-infra Nov 2, 2017

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(aio): update to @angular/core@5.0.0-rc.5 #19702

build(aio): update to @angular/core@5.0.0-rc.5 #19702

IgorMinar commented Oct 13, 2017

mary-poppins commented Oct 17, 2017

gkalpak Oct 18, 2017

gkalpak Oct 18, 2017

gkalpak Oct 18, 2017

gkalpak Oct 18, 2017

gkalpak Oct 18, 2017

IgorMinar Oct 19, 2017

gkalpak Oct 19, 2017

gkalpak Oct 19, 2017

IgorMinar Oct 23, 2017

gkalpak Oct 18, 2017

gkalpak Oct 18, 2017

IgorMinar Oct 19, 2017

mary-poppins commented Oct 19, 2017

IgorMinar commented Oct 19, 2017 via email

googlebot commented Oct 21, 2017

IgorMinar commented Oct 23, 2017

mary-poppins commented Oct 23, 2017

mary-poppins commented Oct 23, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019

build(aio): update to @angular/core@5.0.0-rc.5 #19702

build(aio): update to @angular/core@5.0.0-rc.5 #19702

Conversation

IgorMinar commented Oct 13, 2017

mary-poppins commented Oct 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mary-poppins commented Oct 19, 2017

IgorMinar commented Oct 19, 2017 via email

googlebot commented Oct 21, 2017

IgorMinar commented Oct 23, 2017

mary-poppins commented Oct 23, 2017

mary-poppins commented Oct 23, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019